Overload makeunique to allow true/false, certain keywords (:update, :…#3373
Closed
leei wants to merge 1 commit intoJuliaData:mainfrom
Closed
Overload makeunique to allow true/false, certain keywords (:update, :…#3373leei wants to merge 1 commit intoJuliaData:mainfrom
leei wants to merge 1 commit intoJuliaData:mainfrom
Conversation
…ignore) and a combine function to combine columns.
Member
|
Closing, as #3366 will be followed. Right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #3366 which added a
dupcolkeyword.This one doesn't deprecate
makeuniquebut overloads it instead with three kinds of values allowed:true/falsefor make a new column or raise an error (current behaviour),Functionof two parameters that determines how to combine duplicate column values into one, orThe currently allowed keywords are:
:makeunique– create a new uniquely named column:error– raise an Error:update– update the left-hand column with non-missing values from the right:ignore– ignore the duplicated columnThe implementation is simpler than #3366 and is more flexible. It doesn't address the desire to have a function that would determine how
makeunique=truewould generate new column names, but that could be accomplished by adding a new keyword argument.